Skip to content

respect aliases in SKIP when installing environments#2480

Merged
asottile merged 1 commit into
pre-commit:mainfrom
imc-trading:fix-skip-alias
Aug 11, 2022
Merged

respect aliases in SKIP when installing environments#2480
asottile merged 1 commit into
pre-commit:mainfrom
imc-trading:fix-skip-alias

Conversation

@kmARC

@kmARC kmARC commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Fixes #2478

@asottile

asottile commented Aug 11, 2022

Copy link
Copy Markdown
Member

augh the company account is even worse because I can't fix the branch at all!

asottile
asottile approved these changes Aug 11, 2022
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 6740a17 into pre-commit:main Aug 11, 2022
@kmARC

kmARC commented Aug 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

augh the company account is even worse because I can't fix the branch at all!

Hmmm... I'm not sure what do you mean by that.

I'm planning another PR that helps a lot with monorepos, but that would also come from the company account. Do you have any guideline on how to make it easier for you?

@asottile

asottile commented Aug 12, 2022

Copy link
Copy Markdown
Member

(1) please do not send feature PRs without first discussing them -- monorepos have been a hot topic and I have already set my expectations that there will not be special support for them

(2) when you make PRs from organizations I cannot fixup the branch like I can with user accounts

@kmARC

kmARC commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

(1)
Understood. Our patch is not monorepo-specific, just happens to help with them a lot. I'll open an issue first to discuss.

(2)
Ah, that's quite unfortunate...

@asottile

asottile commented Aug 12, 2022

Copy link
Copy Markdown
Member

and for (1) make sure to search around first -- I'm almost certain it's about cd and there's several discussions about this already

@kmARC kmARC mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SKIP skips invocation by alias but doesn't skip "Installing environment"

2 participants

@kmARC @asottile