add missing param Init in ContainerSpec#1927
Merged
eddumelendez merged 3 commits intodocker-java:masterfrom Sep 19, 2022
ziminghua:AddUtilParam
Merged
add missing param Init in ContainerSpec#1927eddumelendez merged 3 commits intodocker-java:masterfrom ziminghua:AddUtilParam
eddumelendez merged 3 commits intodocker-java:masterfrom
ziminghua:AddUtilParam
Conversation
Contributor
Author
|
@bsideup Can you review this PR? Dose this project still alive? |
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
Thanks for the PR @ziminghua ! Just a small comment about the version where this attribute is available
…ContainerSpec.java Co-authored-by: Eddú Meléndez Gonzales <[email protected]>
Contributor
Author
|
Thank you for reminding me |
eddumelendez
approved these changes
Sep 19, 2022
Member
|
Thanks for the PR @ziminghua ! this is now in master branch |
Contributor
Author
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I use update service cmd,find missing
Initparam in ContainerSpec