Skip to content

Move dependencies to workspace for wasm crate#7794

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-wasm
May 13, 2026
Merged

Move dependencies to workspace for wasm crate#7794
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-wasm

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented May 7, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Centralized and updated dependency management for WebAssembly modules: workspace-level dependency declarations were added and crate-level references aligned to the workspace. This streamlines builds, keeps versions consistent across wasm components, and simplifies future maintenance and updates.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 1fcee42f-3664-42d3-8243-dde832ca2fb5

📥 Commits

Reviewing files that changed from the base of the PR and between 0a3e763 and 3f34e18.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/wasm/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (2)
  • crates/wasm/Cargo.toml
  • Cargo.toml
📝 Walkthrough

Walkthrough

Five WASM-related crate dependencies (console_error_panic_hook, js-sys, serde-wasm-bindgen, wasm-bindgen-futures, web-sys) are defined in the workspace manifest, and crates/wasm/Cargo.toml is updated to reference them via workspace = true instead of hardcoded versions.

Changes

Workspace Dependency Centralization

Layer / File(s) Summary
Workspace Dependency Definitions
Cargo.toml		 Five WASM crate dependencies are added to the workspace [workspace.dependencies] section: console_error_panic_hook, js-sys, serde-wasm-bindgen, wasm-bindgen-futures, and web-sys.
Consumer Crate Alignment
crates/wasm/Cargo.toml		 Five dependency entries switch from hardcoded version pins to workspace = true; web-sys feature list is preserved in the crate manifest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • RustPython/RustPython#7795: Both PRs update Cargo.toml dependency declarations to switch crate versions to workspace = true (workspace-managed manifest changes across different crates).
  • RustPython/RustPython#7789: Both PRs update Cargo manifests to switch crate dependency declarations to workspace = true (main for crates/wasm, retrieved for crates/vm).
  • RustPython/RustPython#7771: Both PRs make Cargo manifest dependency declarations use [workspace.dependencies] by switching crate-specific dependencies to workspace = true (main: crates/wasm, retrieved: crates/common).

Suggested reviewers

  • ShaharNaveh
  • youknowone

Poem

🐰 I hopped through TOMLs with a tidy sigh,
Five deps gathered under one sky,
Versions aligned in a single nest,
Crates breathe easy — workspace blessed!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving WASM crate dependencies to workspace-level management.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone enabled auto-merge (squash) May 9, 2026 15:31
@fanninpm fanninpm force-pushed the move-deps-to-workspace-for-wasm branch from 0a3e763 to 3f34e18 Compare May 13, 2026 02:34
@youknowone youknowone merged commit 7ebffd0 into RustPython:main May 13, 2026
25 checks passed
youknowone pushed a commit to youknowone/RustPython that referenced this pull request May 13, 2026
@fanninpm @youknowone
Move dependencies to workspace for wasm crate (RustPython#7794)
08dedd1 
* Add dependencies from `wasm` crate to workspace

* Declare dependencies as workspace = true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @ShaharNaveh @youknowone