This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients serhiy.storchaka
Date 2021-07-22.20:41:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <[email protected]>
In-reply-to
Content
There are several occurrences of type(literal) in the code of the stdlib where literal is a literal of built-in type: '', 1, [], {}, etc. I suppose it is a remnants of very old code written when str, int, list, dict, etc were functions and not classes.

The proposed PR replaces `type(literal)` with corresponding builtin types. It makes the code cleaner.

I consider also idea of replacing identity or equality checks ("is" or "==") with isinstance(). I suppose that that code was written when built-in  types were not subclassable. But now there is a reason to use isinstance().

See also issue44711.
History
Date User Action Args
2021-07-22 20:41:12serhiy.storchakasetrecipients: + serhiy.storchaka
2021-07-22 20:41:11serhiy.storchakasetmessageid: <[email protected]>
2021-07-22 20:41:11serhiy.storchakalinkissue44712 messages
2021-07-22 20:41:11serhiy.storchakacreate