Message 374556 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	methane
Date	2020-07-29.03:10:35
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
PyDict_Copy() is not used in eval loop or calling functions. So removing clone_combined_dict() is a considerable option. Another option is to use clone_combined_dict() in dict_merge, instead of adding dict_copy2(). Pros: No performance regression. PyDict_Copy() is as fast as before. Cons: Can not "fast copy" split dict and dirty dict. I suppose most dict used by `dict(d)` or `dict.update(d)` is clean and combined. So I will implement the second option.

PyDict_Copy() is not used in eval loop or calling functions. So removing clone_combined_dict() is a considerable option.

Another option is to use clone_combined_dict() in dict_merge, instead of adding dict_copy2().

Pros: No performance regression. PyDict_Copy() is as fast as before.
Cons: Can not "fast copy" split dict and dirty dict.

I suppose most dict used by `dict(d)` or `dict.update(d)` is clean and combined. So I will implement the second option.

History
Date	User	Action	Args
2020-07-29 03:10:35	methane	set	recipients: + methane
2020-07-29 03:10:35	methane	set	messageid: <[email protected]>
2020-07-29 03:10:35	methane	link	issue41431 messages
2020-07-29 03:10:35	methane	create