Message 369619 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	BTaskaya
Recipients	Anthony Sottile, BTaskaya, DahlitzFlorian, gaborjbernat, laloch, pablogsal, remi.lapeyre, serhiy.storchaka
Date	2020-05-22.17:18:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> setting them to None is going to break a lot of those, if possible I'd suggest going back to when they were missing 'lineno' and 'col_offset' will never be none, since both are declared as normal integers. But on the other hand, 'end_lineno' and 'end_col_offset' are declared as optional integers which would make sense to auto initalize them with None, and I dont think it would ever break some code that complies with the ASDL declaration.

> setting them to None is going to break a lot of those, if possible I'd suggest going back to when they were missing

'lineno' and 'col_offset' will never be none, since both are declared as normal integers. But on the other hand, 'end_lineno' and 'end_col_offset' are declared as optional integers which would make sense to auto initalize them with *None*, and I dont think it would ever break some code that complies with the ASDL declaration.

History
Date	User	Action	Args
2020-05-22 17:18:32	BTaskaya	set	recipients: + BTaskaya, serhiy.storchaka, Anthony Sottile, pablogsal, DahlitzFlorian, remi.lapeyre, gaborjbernat, laloch
2020-05-22 17:18:32	BTaskaya	set	messageid: <[email protected]>
2020-05-22 17:18:32	BTaskaya	link	issue40726 messages
2020-05-22 17:18:32	BTaskaya	create