Message 352758 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	zach.ware
Recipients	gregory.p.smith, malin, sir-sigurd, vstinner, zach.ware
Date	2019-09-18.21:48:25
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
I have poked at this a bit and have an implementation that defines a `static inline void _Py_Unreachable()` in pymacro.h, see https://github.com/zware/cpython/commit/d07b4255dc1170155e18db0fea99ec1cb29c2f0a This works on at least macOS and Windows, and we also have prior art for defining static inline functions in headers in GH-10079. If we agree that that's an acceptable solution, I'll open a PR for that change.

I have poked at this a bit and have an implementation that defines a `static inline void _Py_Unreachable()` in pymacro.h, see https://github.com/zware/cpython/commit/d07b4255dc1170155e18db0fea99ec1cb29c2f0a

This works on at least macOS and Windows, and we also have prior art for defining static inline functions in headers in GH-10079.  If we agree that that's an acceptable solution, I'll open a PR for that change.

History
Date	User	Action	Args
2019-09-18 21:48:26	zach.ware	set	recipients: + zach.ware, gregory.p.smith, vstinner, malin, sir-sigurd
2019-09-18 21:48:26	zach.ware	set	messageid: <[email protected]>
2019-09-18 21:48:26	zach.ware	link	issue38205 messages
2019-09-18 21:48:25	zach.ware	create