Message 349466 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	Mark.Shannon, jdemeyer, josh.r, malin, methane, vstinner
Date	2019-08-12.13:13:19
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
I dislike adding these macros: # define Py_UNLIKELY(value) __builtin_expect(!!(value), 0) # define Py_LIKELY(value) __builtin_expect(!!(value), 1) It's too easy to introduce a performance regression by mistake. IHMO PGO compilation already defeats the purpose of these macros. You should use PGO build.

I dislike adding these macros:

#  define Py_UNLIKELY(value) __builtin_expect(!!(value), 0)
#  define Py_LIKELY(value) __builtin_expect(!!(value), 1)

It's too easy to introduce a performance regression by mistake. IHMO PGO compilation already defeats the purpose of these macros. You should use PGO build.

History
Date	User	Action	Args
2019-08-12 13:13:20	vstinner	set	recipients: + vstinner, methane, Mark.Shannon, jdemeyer, josh.r, malin
2019-08-12 13:13:20	vstinner	set	messageid: <[email protected]>
2019-08-12 13:13:20	vstinner	link	issue37774 messages
2019-08-12 13:13:19	vstinner	create