This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients ZackerySpytz, davin, eryksun, serhiy.storchaka, vstinner
Date 2019-05-29.01:17:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <[email protected]>
In-reply-to
Content
> I think it would be best to replace the two calls with 
> PyErr_SetFromWindowsErr(0) (for now).

For now it can at least be implemented inline. For example:

    if (handle == NULL) {
        PyObject *temp = name ? PyUnicode_FromWideChar(name, -1) : NULL;
        PyErr_SetExcFromWindowsErrWithFilenameObjects(PyExc_OSError,
            0, temp, NULL);
        Py_XDECREF(temp);
        handle = INVALID_HANDLE_VALUE;
    }

I think undeprecating the two PyErr_ functions with a modified signature in 3.8 is okay since they were never in the documented API, never in the stable (limited) API, and Py_UNICODE has been a typedef for wchar_t since 3.3.
History
Date User Action Args
2019-05-29 01:17:01eryksunsetrecipients: + eryksun, vstinner, serhiy.storchaka, davin, ZackerySpytz
2019-05-29 01:17:01eryksunsetmessageid: <[email protected]>
2019-05-29 01:17:01eryksunlinkissue36935 messages
2019-05-29 01:17:00eryksuncreate