Message 301221 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	scoder
Recipients	methane, pitrou, rhettinger, scoder, serhiy.storchaka, vstinner
Date	2017-09-04.13:00:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
It's the slot names in "slotdefs". See "update_one_slot()". The time that is saved is mostly the overhead of calling PyDict_GetItem(). I actually tried PyDict_GetItemWithError() first, which is faster due to the lower error handling overhead, before I noticed that the real problem is the repeated lookups of the same name, which can be optimised further by pre-calculating the hash and calling the low-level lookup function.

It's the slot names in "slotdefs". See "update_one_slot()".

The time that is saved is mostly the overhead of calling PyDict_GetItem(). I actually tried PyDict_GetItemWithError() first, which is faster due to the lower error handling overhead, before I noticed that the real problem is the repeated lookups of the same name, which can be optimised further by pre-calculating the hash and calling the low-level lookup function.

History
Date	User	Action	Args
2017-09-04 13:00:24	scoder	set	recipients: + scoder, rhettinger, pitrou, vstinner, methane, serhiy.storchaka
2017-09-04 13:00:24	scoder	set	messageid: <[email protected]>
2017-09-04 13:00:24	scoder	link	issue31336 messages
2017-09-04 13:00:23	scoder	create