Message 289804 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	Oren Milman, amaury.forgeotdarc, belopolsky, meador.inge, serhiy.storchaka
Date	2017-03-18.10:50:10
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
LGTM, but I prefer `overflow > 0` over `overflow == 1`. If use _testcapi the tests should be decorated with cpython_only. But I think that it is better to not use it. Limiting _length_ to C long (rather than size_t) is an implementation detail. The test with _length_ = 1 << 1000 should be enough.

LGTM, but I prefer `overflow > 0` over `overflow == 1`.

If use _testcapi the tests should be decorated with cpython_only. But I think that it is better to not use it. Limiting _length_ to C long (rather than size_t) is an implementation detail. The test with _length_ = 1 << 1000 should be enough.

History
Date	User	Action	Args
2017-03-18 10:50:10	serhiy.storchaka	set	recipients: + serhiy.storchaka, amaury.forgeotdarc, belopolsky, meador.inge, Oren Milman
2017-03-18 10:50:10	serhiy.storchaka	set	messageid: <[email protected]>
2017-03-18 10:50:10	serhiy.storchaka	link	issue29843 messages
2017-03-18 10:50:10	serhiy.storchaka	create