Message 286658 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	python-dev, serhiy.storchaka, vstinner
Date	2017-02-01.17:10:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
Victor: "I plan to run a benchmark when all my patches to reduce the stack consumption will be ready." msg285200 of issue #28870: "I also ran the reliable performance benchmark suite with LTO+PGO. There is no significant performance change on these benchmarks (...)" less_stack.patch: -#define _PY_FASTCALL_SMALL_STACK 5 +#define _PY_FASTCALL_SMALL_STACK 3 With the issue #28870, reducing _PY_FASTCALL_SMALL_STACK value is no more needed. Larger _PY_FASTCALL_SMALL_STACK means better performances, so I prefer to keep the value 5 (arguments). The main change, inline call_function(), was merged, so I close the issue.

Victor: "I plan to run a benchmark when all my patches to reduce the stack consumption will be ready."

msg285200 of issue #28870: "I also ran the reliable performance benchmark suite with LTO+PGO. There is no significant performance change on these benchmarks (...)"

less_stack.patch:

-#define _PY_FASTCALL_SMALL_STACK 5
+#define _PY_FASTCALL_SMALL_STACK 3

With the issue #28870, reducing _PY_FASTCALL_SMALL_STACK value is no more needed. Larger _PY_FASTCALL_SMALL_STACK means better performances, so I prefer to keep the value 5 (arguments).

The main change, inline call_function(), was merged, so I close the issue.

History
Date	User	Action	Args
2017-02-01 17:10:46	vstinner	set	recipients: + vstinner, python-dev, serhiy.storchaka
2017-02-01 17:10:46	vstinner	set	messageid: <[email protected]>
2017-02-01 17:10:46	vstinner	link	issue29227 messages
2017-02-01 17:10:46	vstinner	create