Message 284639 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	xiang.zhang
Recipients	benjamin.peterson, matejcik, xiang.zhang
Date	2017-01-04.14:31:02
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> It does, but "-fwrapv" is not automatically added when you specify custom OPT flags. Indeed I think this is why the changes in #27473 and #1621 make sense. > GCC 6 optimizes away broken overflow checks. I am sorry but I don't understand this. What do you mean by broken overflow checks? Is `if (size > PY_SSIZE_T_MAX - vo.len)` broken?

> It does, but "-fwrapv" is not automatically added when you specify custom OPT flags.

Indeed I think this is why the changes in #27473 and #1621 make sense.

> GCC 6 optimizes away broken overflow checks.

I am sorry but I don't understand this. What do you mean by broken overflow checks? Is `if (size > PY_SSIZE_T_MAX - vo.len)` broken?

History
Date	User	Action	Args
2017-01-04 14:31:02	xiang.zhang	set	recipients: + xiang.zhang, matejcik, benjamin.peterson
2017-01-04 14:31:02	xiang.zhang	set	messageid: <[email protected]>
2017-01-04 14:31:02	xiang.zhang	link	issue29145 messages
2017-01-04 14:31:02	xiang.zhang	create