Message 178370 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	georg.brandl
Recipients	PyryP, amaury.forgeotdarc, ezio.melotti, georg.brandl, pitrou, rhettinger, serhiy.storchaka, vstinner
Date	2012-12-28.07:29:21
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
The patch replaces a Py_CLEAR(tdo->nextlink) with a construct that does, basically, something like this several times: Py_DECREF(tdo->nextlink) tdo->nextlink which is what leads to the issues that Py_CLEAR is supposed to prevent. Therefore I think this patch is not correct.

The patch replaces a

 Py_CLEAR(tdo->nextlink)

with a construct that does, basically, something like this several times:

 Py_DECREF(tdo->nextlink)
 tdo->nextlink

which is what leads to the issues that Py_CLEAR is supposed to prevent.  Therefore I think this patch is not correct.

History
Date	User	Action	Args
2012-12-28 07:29:22	georg.brandl	set	recipients: + georg.brandl, rhettinger, amaury.forgeotdarc, pitrou, vstinner, ezio.melotti, PyryP, serhiy.storchaka
2012-12-28 07:29:22	georg.brandl	set	messageid: <[email protected]>
2012-12-28 07:29:22	georg.brandl	link	issue13454 messages
2012-12-28 07:29:21	georg.brandl	create