Message 126499 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	lavajoe
Recipients	lavajoe
Date	2011-01-18.22:31:34
SpamBayes Score	1.6960097e-05
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
There are two issues with conversion to Python 3: 1. It raise "KeyError". This is because the Mon2num dictionary keys are strings (str), not bytes objects (note that many other strings in imaplib have been updated, but not Mon2num). 2. The sign character of the TZ offset (e.g. -0700) is compared to the string (str) '-', not bytes array b'-', so the compare is never true, causing a large error when the TZ offset is negative. Patch attached that also adds a unit test.

There are two issues with conversion to Python 3:

1. It raise "KeyError".  This is because the Mon2num dictionary keys are strings (str), not bytes objects (note that many other strings in imaplib have been updated, but not Mon2num).

2. The sign character of the TZ offset (e.g. -0700) is compared to the string (str) '-', not bytes array b'-', so the compare is never true, causing a large error when the TZ offset is negative.

Patch attached that also adds a unit test.

History
Date	User	Action	Args
2011-01-18 22:31:41	lavajoe	set	recipients: + lavajoe
2011-01-18 22:31:40	lavajoe	set	messageid: <[email protected]>
2011-01-18 22:31:34	lavajoe	link	issue10939 messages
2011-01-18 22:31:34	lavajoe	create